Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Refactor to ES2015+ #55

Open
adamrenklint opened this issue Oct 31, 2016 · 2 comments
Open

Refactor to ES2015+ #55

adamrenklint opened this issue Oct 31, 2016 · 2 comments

Comments

@adamrenklint
Copy link
Owner

No description provided.

@zcei
Copy link

zcei commented Mar 7, 2017 •
edited
Loading

Just executed Lebab on the lib/ folder just for fun, and apart from mocking Tuna in lib/Effect.js:11 it seems to do its job quite well.

Applied:

  • arrow (afterwards change the Tuna thing back)
  • class
  • let
  • template
  • default-param
  • destruct-param

I have no clue how good your actual coverage is, but tests are still passing.
Just wanted to mention it, as it might eases the burden for you to start off with the refactor.

Loving your sound projects ❤️

@adamrenklint
Copy link
Owner Author

Oh, that's cool. Could you submit a PR?

@zcei zcei mentioned this issue Mar 8, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to ES2015 zcei/bap
2 participants
@adamrenklint @zcei