Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt_framework: npm install issue pngquant-bin #3002

Closed
oliverfoster opened this issue Dec 22, 2020 · 1 comment
Closed

adapt_framework: npm install issue pngquant-bin #3002

oliverfoster opened this issue Dec 22, 2020 · 1 comment
Labels
bug

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Dec 22, 2020 •
edited
Loading

Subject of the issue

Fresh computer. New node installation.

pngquant-bin fails compilation tasks.

Requires install of npm install --global windows-build-tools

Your environment

  • framework master
  • windows 10, node 14.15.3

Reference imagemin/imagemin-pngquant#46
@oliverfoster
Copy link
Member Author

@moloko as per your original suggestion, optional dependencies could solve this: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#optionaldependencies

@oliverfoster oliverfoster mentioned this issue Jan 5, 2021
Merged
@moloko moloko mentioned this issue Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliverfoster