Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Combining Diacritical Marks not rendered correctly #184

Open
2 of 3 tasks
LuoZijun opened this issue Apr 19, 2023 · 2 comments
Open
2 of 3 tasks

Some Combining Diacritical Marks not rendered correctly #184

LuoZijun opened this issue Apr 19, 2023 · 2 comments

Comments

@LuoZijun
Copy link

Prerequisites

  • If you are reporting an issue that affects glyphs for characters for a particular region or regions, did you verify that the characters are within the supported scope of the region or regions? This generally means GB 18030 or Tōngyòng Guīfàn Hànzìbiǎo (通用规范汉字表) for China, Big Five or CNS 11643 Planes 1 & 2 for Taiwan, HKSCS-2016 for Hong Kong, the JIS standards for Japan, and KS X 1001 and KS X 1002 for Korea.
  • Did you thoroughly search the open and closed issues to avoid reporting a duplicate issue?
  • Did you go through the official font readme file to better understand the scope of the project, to include the Known Issues section at the very end?

Description

I don't know if the characters used for Hanyu Pinyin are the focus of this project, if so, I found several accented characters that were not displayed correctly.

character set: Ê̄ Ê̌ M̄ M̌ M̀ N̄ ê̄ ê̌ m̄ m̌ m̀ n̄ ◌̄ ◌́ ◌̌ ◌̀ ·◌

Ê̄ (U+00CA U+0304) Ê̌ (U+00CA U+030C)
M̄ (U+004D U+0304) M̌ (U+004D U+030C) M̀ (U+004D U+0300) 
N̄ (U+004E U+0304)

ê̄ (U+00EA U+0304) ê̌ (U+00EA U+030C) 
m̄ (U+006D U+0304) m̌ (U+006D U+030C) m̀ (U+006D U+0300) 
n̄ (U+006E U+0304)

U+0304  ◌̄
U+0301 ◌́ 
U+030C  ◌̌ 
U+0300  ◌̀ 
U+00B7 ·◌

image

Note: Green means the display is correct.

@punchcutter
Copy link
Member

Only M̌ N̄ m̌ n̄ are not precomposed characters in the font, but the others you mention are in the font and display correctly so I'm not sure why you added those.

@LuoZijun
Copy link
Author

Only M̌ N̄ m̌ n̄ are not precomposed characters in the font, but the others you mention are in the font and display correctly so I'm not sure why you added those.

Sorry, now I re-updated the details: adobe-fonts/source-serif#118 (comment)

actually not only these characters:

not precomposed characters: M̌ m̌ N̄ n̄ ◌̄ ◌́ ◌̌ ◌̀

not supported characters: Ĉ Ŝ Ẑ Ŋ ĉ ŝ ẑ ŋ

glyphs look weird characters:

  1. I Ī Í Ǐ Ì Ế Ề ế ề (single Unicode character)
  2. Ế Ề ế ề, I Ī Í Ǐ Ì (Combining Diacritical Marks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants