Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominal form of U+1178 ᅸ, nominal form & vjmo01 glyph of U+D7B5 ힵ #25

Closed
acuteaccent opened this issue Apr 8, 2017 · 6 comments
Closed
Assignees

Comments

@acuteaccent
Copy link

acuteaccent commented Apr 8, 2017

  1. The nominal form of U+1178 ᅸ is wrong. U+1178 is ㅑ + ㅗ, not ㅑ + ㅛ (ㅑ + ㅛ is U+1179 ᅹ).
  2. The nominal form and the vjmo01 glyph of U+D7B5 ힵ are wrong. U+D7B5 is ㅜ + ㅕ, not ㅗ + ㅕ (ㅗ +ㅕ is U+D7B0 ힰ).
@acuteaccent acuteaccent changed the title Nominal form of U+1178 ᅸ Nominal form of U+1178 ᅸ, nominal form & vjmo01 of U+D7B5 ힵ Apr 8, 2017
@acuteaccent acuteaccent changed the title Nominal form of U+1178 ᅸ, nominal form & vjmo01 of U+D7B5 ힵ Nominal form of U+1178 ᅸ, nominal form & vjmo01 glyph of U+D7B5 ힵ Apr 8, 2017
@kenlunde kenlunde self-assigned this Apr 8, 2017
@kenlunde kenlunde added the bug label Apr 8, 2017
@kenlunde
Copy link
Contributor

kenlunde commented Apr 8, 2017

Thank you. The following three glyphs need adjustment: uni1178, uniD7B5, and uniD7B5.vjmo01.

@kenlunde
Copy link
Contributor

kenlunde commented Apr 10, 2017

I received the fixed glyphs from Sandoll's designer, which are shown below in the ExtraLight, Medium, and Heavy weights. The mappings from the backend CIDs to the glyph names are below:

CID+121 = uni1178
CID+446 = uniD7B5
CID+12563 = uniD7B5.vjmo01

shserif-issue-25-fix

Note that uniD7B5.vjmo01 is shown before it is shifted to the left and its horizontal advance is zeroed out (this is to be able to see the fix more clearly, because it would otherwise display over the glyph for uniD7B5).

@acuteaccent
Copy link
Author

Awesome.

@acuteaccent
Copy link
Author

BTW, I checked all the glyphs of conjoining hangul jamo (nominal forms, ljmo0[1-6], vjmo0[1-2], and tjmo0[1-4]; haven't checked the high-frequency 500 archaic hangul syllables) in Source Han Serif. I found no other errors besides the ones I have reported so far.

@kenlunde
Copy link
Contributor

Thank you for the positive report. Also, thank you for checking these glyphs and reporting the issues that resulted in 22 glyph corrections. The fixes will be reflected in the first dot-release.

@kenlunde
Copy link
Contributor

kenlunde commented Apr 11, 2017

Consolidated with Issue #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants