Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeinstancesufo] fails when building single instance (-i option) #922

Closed
frankrolf opened this issue Aug 21, 2019 · 4 comments
Closed
Labels

Comments

@frankrolf
Copy link
Member

I’ve been getting the following traceback whenever I try to replace a single instance:

[Masters] makeinstancesufo -i 0 -d test.designspace
ERROR:afdko.makeinstancesufo:ufoProcessor error
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/ufoProcessor/__init__.py", line 117, in build
    r = document.generateUFO(processRules=processRules)
  File "/usr/local/lib/python3.7/site-packages/ufoProcessor/__init__.py", line 310, in generateUFO
    font.save(path, self.ufoVersion)
  File "/usr/local/lib/python3.7/site-packages/defcon/objects/font.py", line 820, in save
    structure=structure,
  File "/usr/local/lib/python3.7/site-packages/fontTools/ufoLib/__init__.py", line 960, in __init__
    self.layerContents = OrderedDict(self._readLayerContents(validate))
  File "/usr/local/lib/python3.7/site-packages/fontTools/ufoLib/__init__.py", line 599, in _readLayerContents
    raise UFOLibError(error)
fontTools.ufoLib.errors.UFOLibError: A glyphset does not exist at glyphs.
ERROR:afdko.makeinstancesufo:A glyphset does not exist at glyphs.

Deleting the instance and completely re-building it works, as well as complete re-building of all instances.

I can prepare some test files if needed.

@frankrolf
Copy link
Member Author

The promised test case is attached.

To reproduce the error:

  • cd to the Masters directory
  • run makeinstancesufo -d test.designspace
  • run makeinstancesufo -i 0 -d test.designspace

The 2nd command will fail with the above traceback.
Re-running makeinstancesufo -d test.designspace will show no problems.

makeinstancesufo test case.zip

@miguelsousa
Copy link
Member

After a closer look, I believe this got fixed by 87a5bab which was part of #899 (an effort to maximize makeinstancesufo coverage). I'm planning to make a dot release either tomorrow or Friday, which will include 2 weeks-worth of fixes and enhancements. I'll close this issue once the release is out.

@miguelsousa
Copy link
Member

@frankrolf version 3.0.1 is out. Please check that it fixes this issue. Thanks.

@frankrolf
Copy link
Member Author

3.0.1 works – thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants