Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Improvements to About dialog contributors list #3012

Closed
njx opened this issue Mar 1, 2013 · 4 comments
Closed

Improvements to About dialog contributors list #3012

njx opened this issue Mar 1, 2013 · 4 comments
Assignees
Milestone

Comments

@njx
Copy link
Contributor

njx commented Mar 1, 2013

  1. If the fetch of the contributors from GitHub fails, hide the spinner and show a message below like: "Lots of people (but we can't access GitHub right now to find out who)."
  2. _getContributorsInformation() is no longer necessary--you can just replace it with the call to $.getJSON() (since the promise returned by that is exactly the promise you want--the extra promise that _getContributorsInformation() currently returns is redundant now, since all it does is pass through the resolve/reject from the original promise).
@TomMalbran
Copy link
Contributor

Thanks for merging it. I just added some comments to Tuckers request.

  1. That looks great as a text.
  2. I agree, I separate that part before mainly for the cache, but since is gone, this can be gone too.

@njx
Copy link
Contributor Author

njx commented Mar 1, 2013

Looks good, thanks for the quick fix! Closing.

@njx njx closed this as completed Mar 1, 2013
@TomMalbran
Copy link
Contributor

Should this be changed to sprint 21 now?

@njx
Copy link
Contributor Author

njx commented Mar 2, 2013

Yup, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants