Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Two ViewCommandHandlers unit tests are failing due to font size changes on Mac. #3794

Closed
RaymondLim opened this issue May 13, 2013 · 5 comments
Closed

Two ViewCommandHandlers unit tests are failing due to font size changes on Mac. #3794

RaymondLim opened this issue May 13, 2013 · 5 comments
Milestone
sprint 25

Comments

@RaymondLim
Copy link
Contributor

Run ViewCommandHandlers under Integration in Jasmine window.

Result: You get two failures with the following error messages.
Error: Expected 18 to be 17.
Error: Expected 15 to be 16.
@ghost ghost assigned redmunds May 13, 2013
@RaymondLim
Copy link
Contributor Author

Assign it to @redmunds since I suspect this has to do with either pull request #3757 or #3568.

@redmunds
Copy link
Contributor

The recent attempts to fix #3478 exposed a bug in those tests. The Editor.getTextHeight() function returns line-height, not font-size, so calculating expected size using + 2 is incorrect. Pull request #3757 change the ration of line-height to font-size from 1.25 to 1.3, so the luck of these tests passing finally ran out.

@redmunds redmunds mentioned this issue May 13, 2013
Merged
@pthiess
Copy link
Contributor

pthiess commented May 14, 2013

Reviewed

@jasonsanjose
Copy link
Member

FBNC @RaymondLim

@RaymondLim
Copy link
Contributor Author

Confirmed fix.

@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sprint 25
Development

No branches or pull requests
4 participants
@jasonsanjose @redmunds @RaymondLim @pthiess