Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this package doesn't work in wasm #284

Closed
Milerius opened this issue Jul 17, 2021 · 3 comments
Closed

this package doesn't work in wasm #284

Milerius opened this issue Jul 17, 2021 · 3 comments

Comments

@Milerius
Copy link
Contributor

Milerius commented Jul 17, 2021

Capture d’écran 2021-07-17 à 10 04 50

I think websocket in the browser should work - why it is not the case ? (gorilla doesn't support wasm)
gorilla/websocket#432

https://github.com/nhooyr/websocket it's seems supported on this package, would be worth to drop gorilla websocket tbh

For me it's a bit critical, being able to build for wasm should be a priority nowadays in crypto, most of the project are moving towards this direction especially for decentralized node in the browser

cc @adshao

@adshao
Copy link
Owner

adshao commented Jul 27, 2021

Capture d’écran 2021-07-17 à 10 04 50

I think websocket in the browser should work - why it is not the case ? (gorilla doesn't support wasm)
gorilla/websocket#432

https://github.com/nhooyr/websocket it's seems supported on this package, would be worth to drop gorilla websocket tbh

For me it's a bit critical, being able to build for wasm should be a priority nowadays in crypto, most of the project are moving towards this direction especially for decentralized node in the browser

cc @adshao

Hi @Milerius , I think it's ok to use https://github.com/nhooyr/websocket instead of gorilla websocket, do you want to submit a PR for it? or I'll try to implement it in next month.

@Milerius
Copy link
Contributor Author

Capture d’écran 2021-07-17 à 10 04 50 I think websocket in the browser should work - why it is not the case ? (gorilla doesn't support wasm) [gorilla/websocket#432](https://github.com/gorilla/websocket/issues/432) https://github.com/nhooyr/websocket it's seems supported on this package, would be worth to drop gorilla websocket tbh For me it's a bit critical, being able to build for wasm should be a priority nowadays in crypto, most of the project are moving towards this direction especially for decentralized node in the browser cc @adshao

Hi @Milerius , I think it's ok to use https://github.com/nhooyr/websocket instead of gorilla websocket, do you want to submit a PR for it? or I'll try to implement it in next month.

I have a working implementation on my machine i can submit a patch this week

@Milerius
Copy link
Contributor Author

Thanks for the merge @adshao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants