Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1passwordExtension and cocoapods 0.39 issue #268

Closed
jbbichon opened this issue Oct 16, 2015 · 3 comments
Closed

1passwordExtension and cocoapods 0.39 issue #268

jbbichon opened this issue Oct 16, 2015 · 3 comments
Assignees
Labels

Comments

@jbbichon
Copy link
Contributor

Hello Guys,

It seems that cocoapods 0.39 and 1PasswordExtension encounter some issue on a clean pod update

I check in the header path file and one is missing since I update to cocoapods 0.39 :

"${PODS_ROOT}/Headers/Public/1PasswordExtension/OnePasswordExtension"

the other one is still present but not recursive (${PODS_ROOT}Headers/Public/1PasswordExtension). it result in a crash when we try to build the project:

import "OnePasswordExtension.h" file not found

Cordially,

Jb

@jbbichon jbbichon changed the title 1passwordExtension and cocoapods 1.39 issue 1passwordExtension and cocoapods 0.39 issue Oct 16, 2015
@radazzouz radazzouz self-assigned this Oct 16, 2015
@radazzouz
Copy link
Contributor

Hi @jbbichon,

Thanks for taking the time to write in 👍

I did see indeed on the Twittersphere reports about missing headers after updating to CocoaPods 0.39.0. However, I couldn't reproduce it here locally and here's what I did:

  • I updated to CocoaPods 0.39.
  • I used the attached sample project and I "cleaned" the project by trashing the following files and directories:

  • I ran pod install

As a result the demo app, ACME built and ran just fine.

Could you please try and reproduce the issue using my sample project?

Cheers!

@jbbichon
Copy link
Contributor Author

mmm...I see, we are not using "use_frameworks!" command in our podfile and it fail (some other project just don't support it).

I made a pull request with a small fix that seems to work with both mode (with and without "use_frameworks!"). please have a try ;)

Cheers!

@radazzouz
Copy link
Contributor

Thanks again @jbbichon for the detailed steps to reproduce 👍

I confirm that PR #270 fixed it. We just shipped version 1.6.3 of the 1Password App Extension API with this fix. So you can point to master of to the 1.6.3 tag,

Closing this issue.

Bon weekend! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants