Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert on ValueError exception messages #65

Closed
ahawker opened this issue Oct 29, 2017 · 0 comments
Closed

Assert on ValueError exception messages #65

ahawker opened this issue Oct 29, 2017 · 0 comments

Comments

@ahawker
Copy link
Owner

ahawker commented Oct 29, 2017

There are many cases where a ValueError can be raised by any number of functions across most of the modules in this package.

I am relatively confident that all of the @pytest.raises(ValueError) calls are correct based on code coverage metrics. However, I was proven wrong today and had to address some of them with #61.

The scope of this task is to go through all tests that use @pytest.raises, capture the exception and perform an additional assertion of the exception message to confirm that we're hitting the exact code path expected.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant