readthedocs build failing

[ltalirz]

See https://readthedocs.org/projects/aiida-core/builds/16126865/

ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/docs/checkouts/readthedocs.org/user_builds/aiida-core/envs/stable/lib/python3.8/site-packages/markupsafe/init.py)

tagging @chrisjsewell @sphuber

[sphuber]

The culprit is markupsafe==2.1.0 that was release 6 hours ago.

[sphuber]

Issue on jinja2 for fixing it is here: pallets/jinja#1587

[sphuber]

Funnily enough, both are pallets packages, so they are breaking their own packages 😅

[aditya-kar]

I've opened PR #1589 for Jinja 2.x. This should fix pallets/jinja#1587

[davidism]

You are using an unsupported version of Jinja, please update to the latest version if possible. Additionally, please read https://hynek.me/articles/semver-will-not-save-you/, then use a tool like pip-tools to pin your dependencies and control when you get updates. Be sure to run your tests with deprecation warnings treated as errors so that you get notified of these types of changes early.

[chrisjsewell]

Additionally, please read hynek.me/articles/semver-will-not-save-you

Thanks, but I'm well aware of these blog posts, so let's not get into the whole upper pinning discussion here 😅

You've provided me an interesting example for the discussion I am involved in though: executablebooks/meta#648 (comment)

[CasperWA]

Will this be implemented as part of a patch update to the latest public release of AiiDA in the near future?

[sphuber]

We are close to releasing 2.0.0b1 early next week. This should include this fix.

[CasperWA]

We are close to releasing 2.0.0b1 early next week. This should include this fix.

But no backport/hotfix for v1.x?

[sphuber]

No probably will do that as well. The support branch already has another cherry-picked fix that would merit a release

[CasperWA]

Much appreciated. I'm seeing this error when simply installing AiiDA on a fresh environment and trying to import a DB... So I'd consider it critical :)

[sphuber]

There you go: https://pypi.org/project/aiida-core/1.6.6/

[CasperWA]

It seems this did not fix the issue at hand. Since the markupsafe restriction is in the docs extra it isn't respected when installing AiiDA straight up.
When installing AiiDA straight up, markupsafe is still a (sub)dependency, and then verdi import fails. I.e., AiiDA v1.6.6 can be considered broken.

[sphuber]

Round number two: https://pypi.org/project/aiida-core/1.6.7/ 🙏

[CasperWA]

Halleluja! 😄