Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The configuration is not pretty displayed in Graylog v5 #50

Open
frantz45 opened this issue Sep 1, 2023 · 2 comments
Open

The configuration is not pretty displayed in Graylog v5 #50

frantz45 opened this issue Sep 1, 2023 · 2 comments

Comments

@frantz45
Copy link
Collaborator

frantz45 commented Sep 1, 2023

With Graylog v5.1.4 and Logging Alert v5.1.0 the configuration is not pretty displayed:

image

As you can see the name is too long.
I propose to change this ugly long name by "Logging Alert".

@frantz45 frantz45 changed the title The configuration display is not pretty The configuration display is not pretty in Graylog v5 Sep 1, 2023
@frantz45 frantz45 changed the title The configuration display is not pretty in Graylog v5 The configuration is not pretty displayed in Graylog v5 Sep 1, 2023
@c8y3
Copy link
Collaborator

c8y3 commented Jan 30, 2024

The problem is that the name which is displayed is hard-coded inside the graylog2-server interface code-base, rather than brought by the plugin. So graylog2-server must know the plugin before hand.
More precisely, the name which is displayed on the configuration page is the displayName (https://github.com/Graylog2/graylog2-server/blob/5.1.3/graylog2-web-interface/src/components/configurations/PluginsConfig.tsx#L93)
To compute the displayNamegraylog searches (https://github.com/Graylog2/graylog2-server/blob/5.1.3/graylog2-web-interface/src/components/configurations/PluginsConfig.tsx#L88) in the table of predefined plugin display names https://github.com/Graylog2/graylog2-server/blob/5.1.3/graylog2-web-interface/src/components/configurations/PluginsConfig.tsx#L45. If it doesn't find it there, it uses the configType.
The legacy collector system is present in the table of predefined plugins display names, but not our plugin (obviously) :(
The list of plugins graylog knows is listed here: https://github.com/Graylog2/graylog2-server/blob/5.1.3/graylog2-web-interface/src/components/configurations/ConfigurationTypes.ts#L29

This is quite a hack. We could open a ticket for Graylog...

@c8y3
Copy link
Collaborator

c8y3 commented Jan 30, 2024

This issue has already been raised in issue Graylog2/graylog2-server#15939. It is solved on December 20 by PR Graylog2/graylog2-server#17407.
Unfortunately, it is only present on master Graylog2/graylog2-server@b8bea5c and not yet available in either the latest released 5.1 (5.1.10) or the latest released version (5.2.3)
Also, see branches 5.1 and 5.2 histories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants