34_deploy_controlplane_target.sh creates extra control plane

[rkjain]

Description
./tools/deployment/34_deploy_controlplane_target.sh creates an extra control plane node that remains in provisioning state.

Steps To Reproduce
use v2.0 branch of airshipctl and treasuremap, and followed the site authoring/deployment guide to create 6 node cluster in ericsson lab.

airship@as2-1-r:~$ sudo kubectl  --kubeconfig /home/airship/.airship/kubeconfig --context target-cluster get machines
NAME                         PROVIDERID                                      PHASE
cluster-controlplane-22977   metal3://dd33ef25-a348-462a-b125-e20c6a52f1bd   Running
cluster-controlplane-9dg7s                                                   Provisioning
cluster-controlplane-gjvvr   metal3://7365c9e8-8322-4969-8db7-916c0f00760b   Running
cluster-controlplane-nqv7p   metal3://136a085a-fae8-412d-a4bf-dd331a533437   Running
worker-1-5bc87ff868-2x5qz    metal3://534c9542-3250-4806-9f70-2552c75f964e   Running
worker-1-5bc87ff868-6tjhh    metal3://32292183-6617-450e-a230-ed4ac02369dd   Running
worker-1-5bc87ff868-dwg5z    metal3://fde274cb-cf6e-42ff-b5ca-32ca7310e9d0   Running

Expected behavior
There should only be 3 control planes

airship@as2-1-r:~$ sudo kubectl  --kubeconfig /home/airship/.airship/kubeconfig --context target-cluster get machines
NAME                         PROVIDERID                                      PHASE
cluster-controlplane-22977   metal3://dd33ef25-a348-462a-b125-e20c6a52f1bd   Running
cluster-controlplane-gjvvr   metal3://7365c9e8-8322-4969-8db7-916c0f00760b   Running
cluster-controlplane-nqv7p   metal3://136a085a-fae8-412d-a4bf-dd331a533437   Running
worker-1-5bc87ff868-2x5qz    metal3://534c9542-3250-4806-9f70-2552c75f964e   Running
worker-1-5bc87ff868-6tjhh    metal3://32292183-6617-450e-a230-ed4ac02369dd   Running
worker-1-5bc87ff868-dwg5z    metal3://fde274cb-cf6e-42ff-b5ca-32ca7310e9d0   Running

[ermurugesanbe]

Please assign to me

[eak13]

@ermurugesanbe all yours

[ermurugesanbe]

by changing given manifest to replicate only first control-plane instead of adding new control-plane its fixed.

[ermurugesanbe]

Hi @rkjain,
kindly verify and close the issue.

[rkjain]

Thank you murugesan for getting this fixed. I now understand that the reference manifests were creating an extra control plane, and that part had to be commented for this to work.