Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect node labels on worker nodes during bare metal deployment #142

Closed
rkjain opened this issue May 10, 2021 · 3 comments
Closed

incorrect node labels on worker nodes during bare metal deployment #142

rkjain opened this issue May 10, 2021 · 3 comments
Assignees
@sreejithpunnapuzha
Labels
bug Something isn't working priority/medium Default priority for items size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]]
Milestone
v2.1

Comments

@rkjain
Copy link

rkjain commented May 10, 2021

Description
We used v2.0 of airshipctl and treasuremap to create a 6 node cluster (3 CP, 3 Workers)in ericsson lab. The deployment was successful. However, the worker nodes are also labelled as master.

Steps To Reproduce
Follow site authoring/deployment guide for baremetal deployment.

airship@as2-1-r:~$ sudo kubectl  --kubeconfig /home/airship/.airship/kubeconfig --context target-cluster get nodes
[sudo] password for airship: 
NAME    STATUS   ROLES           AGE     VERSION
bm129   Ready    master          5h25m   v1.18.6
bm130   Ready    master          4h31m   v1.18.6
bm131   Ready    master          4h48m   v1.18.6
bm132   Ready    master,worker   4h8m    v1.18.6
bm133   Ready    master,worker   4h8m    v1.18.6
bm134   Ready    master,worker   4h8m    v1.18.6

Expected behavior

airship@as2-1-r:~$ sudo kubectl  --kubeconfig /home/airship/.airship/kubeconfig --context target-cluster get nodes
[sudo] password for airship: 
NAME    STATUS   ROLES           AGE     VERSION
bm129   Ready    master          5h25m   v1.18.6
bm130   Ready    master          4h31m   v1.18.6
bm131   Ready    master          4h48m   v1.18.6
bm132   Ready    worker   4h8m    v1.18.6
bm133   Ready    worker   4h8m    v1.18.6
bm134   Ready    worker   4h8m    v1.18.6
@rkjain rkjain added bug Something isn't working triage labels May 10, 2021
@imarijitbose
Copy link
Contributor

This script 35 is causing the master label at the worker nodes.
https://review.opendev.org/plugins/gitiles/airship/treasuremap/+/refs/heads/v2.0/tools/deployment/35_deploy_worker_node.sh#63. Working to get it corrected

This was referenced May 11, 2021
Closed
Open
@jezogwza jezogwza added priority/medium Default priority for items and removed triage labels May 12, 2021
@jezogwza jezogwza added this to the v2.1 milestone May 12, 2021
@sreejithpunnapuzha sreejithpunnapuzha self-assigned this May 12, 2021
@sreejithpunnapuzha sreejithpunnapuzha added the size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]] label May 13, 2021
@sreejithpunnapuzha
Copy link
Member

sreejithpunnapuzha commented May 16, 2021 •
edited
Loading

Fix for this issue is https://review.opendev.org/c/airship/treasuremap/+/791608

@sreejithpunnapuzha
Copy link
Member

The above mentioned commit is merged. Gates are working as expected. hence closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreejithpunnapuzha sreejithpunnapuzha

Labels
bug Something isn't working priority/medium Default priority for items size m 2-5 days [moderate complexity, generic code, or enhancement to existing feature]]
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@rkjain @imarijitbose @jezogwza @sreejithpunnapuzha