Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagChipDeletable with Independent Callback #161

Open
mlajkim opened this issue Jan 19, 2024 · 0 comments
Open

TagChipDeletable with Independent Callback #161

mlajkim opened this issue Jan 19, 2024 · 0 comments
Labels
refactor Refactor codes into the writing convention rules

Comments

@mlajkim
Copy link
Contributor

mlajkim commented Jan 19, 2024

Background

src/components/molecule_tag_button_chunk/index.deletable.tsx

has a weird structure that onPutWordTagDeleted is defined in src/components/molecule_tag_button_chunk/index.deletable.tsx,
but it can be simply defined within the TagChipDeletable

TODOs

- [ ] Refactor to fix the problem defined in background
- [ ] use only `onClick()` for each component
@mlajkim mlajkim added the refactor Refactor codes into the writing convention rules label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactor codes into the writing convention rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlajkim