Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot VI cant handle varied coordinate systems #77

Open
1jamesthompson1 opened this issue Dec 8, 2022 · 1 comment
Open

ggplot VI cant handle varied coordinate systems #77

1jamesthompson1 opened this issue Dec 8, 2022 · 1 comment

Comments

@1jamesthompson1
Copy link
Contributor

Currently, the VI method will only work if the plots coordinate first calls is either "CoordCartesian" or "CoordFixed".

This means that a plot like:

ggplot(mtcars, aes(mpg,disp)) +
  geom_point() + coord_flip()

Will print out a message like this:

VI cannot process ggplot objects with flipped or non-Cartesian coordinates

I think that the VI method is actually capable of processing different types of Coord systems like flipped with ease.

It seems that

  if (!(.getGGCoord(x, xbuild) %in% c("CoordCartesian", "CoordFixed"))) {
    message("VI cannot process ggplot objects with flipped or non-Cartesian coordinates")
    return(NULL)
  }

At the start of .VIstruct.ggplot() and .getGGCoord() need to be updated.

@ajrgodfrey
Copy link
Owner

ajrgodfrey commented Dec 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants