Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation pattern - the title should probably be an H1 #413

Closed
joelanman opened this issue Jun 27, 2018 · 3 comments
Closed

Confirmation pattern - the title should probably be an H1 #413

joelanman opened this issue Jun 27, 2018 · 3 comments
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@joelanman
Copy link
Contributor

On a confirmation page the title is currently and H2 - it should probably be an H1

https://design-system.service.gov.uk/patterns/confirmation-pages/default/index.html

@joelanman joelanman added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jun 27, 2018
@dashouse
Copy link

I think we should certainly make the change so it's an<h1> by default but make it configurable, either to allow for an <h2> if desired or perhaps using the same isPageHeading: true logic as the <legend> and <label>?

For example, I believe DVLA use a confirmation panel with an <h2> because the panel is preceded by the vehicles registration mark as the <h1>

@NickColley
Copy link
Contributor

titleLevel: 2 default (1)?

@kr8n3r
Copy link
Contributor

kr8n3r commented Jul 16, 2018

updated in #439

@kr8n3r kr8n3r closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Development

No branches or pull requests

4 participants