diff --git a/CHANGELOG.md b/CHANGELOG.md index 6c4939a022..ad2d6bcadf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,10 @@ can now be overwritten by setting the `assetUrl` variable. ([PR #847](https://github.com/alphagov/govuk-frontend/pull/847)) +- Only underline the logo in the header on underline when users have overridden + colours in their browser, rather than it appearing underlined all the time + ([PR #926](https://github.com/alphagov/govuk-frontend/pull/926)) + 🔧 Fixes: - Replace conflicting `js-hidden` class used within the tabs component with a new modifier class. diff --git a/src/components/header/_header.scss b/src/components/header/_header.scss index 929ea5cc61..780d29879b 100644 --- a/src/components/header/_header.scss +++ b/src/components/header/_header.scss @@ -101,14 +101,16 @@ &:link, &:visited { - margin-bottom: -1px; // Negate transparent bottom border - border-bottom: 1px solid transparent; text-decoration: none; } &:hover, &:active { - border-bottom-color: currentColor; + // Negate the added border + margin-bottom: -1px; + // Omitting colour will use default value of currentColor – if we + // specified currentColor explicitly IE8 would ignore this rule. + border-bottom: 1px solid; } }