Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some components active states are broken in compatibility mode #1562

Closed
NickColley opened this issue Sep 9, 2019 · 1 comment · Fixed by #1564
Closed

Some components active states are broken in compatibility mode #1562

NickColley opened this issue Sep 9, 2019 · 1 comment · Fixed by #1564
Assignees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@NickColley
Copy link
Contributor

NickColley commented Sep 9, 2019

Screen Shot 2019-09-09 at 17 36 36

We have run into this issue before here: #1310

This seems to be a problem for other components too, you can see the impact live on GOV.UK: https://www.gov.uk/register-to-vote

You can reproduce this by going to:
http://localhost:3000/components/button/start-link/preview?legacy=1

And changing the href to something unique in the example yaml file.

This may be an issue with other components too.

@NickColley NickColley added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) awaiting triage Needs triaging by team labels Sep 9, 2019
@NickColley
Copy link
Contributor Author

Not sure if there's a more holistic approach we can have here.

Should all hrefs get automatically be cache busted?

If we did that how do we test visited states?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
Development

Successfully merging a pull request may close this issue.

2 participants