Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Unlabelled graphic' read out within header using NVDA #1636

Closed
36degrees opened this issue Nov 12, 2019 · 5 comments · Fixed by #1724
Closed

'Unlabelled graphic' read out within header using NVDA #1636

36degrees opened this issue Nov 12, 2019 · 5 comments · Fixed by #1724
Assignees
Labels
accessibility 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve. 🔍 investigation

Comments

@36degrees
Copy link
Contributor

From alphagov/govuk-design-system-backlog#97 (comment):

On reviewing the header https://design-system.service.gov.uk/components/header/default/index.html# in NVDA for Windows the png is declared as "Unlabelled graphic" (text from NVDA text viewer below)

Header – Example – GOV.UK Design System document
visited link
Unlabelled graphic
To get missing image descriptions, open the context menu.

GOV.UK

To make NVDA ignore the tag I'd suggest giving the a role="presentation" too as the same role attribute in the tag doesn't seem to carry through.

I've been able to reproduce this using Chrome + NVDA on Windows 10.

@36degrees 36degrees added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) accessibility awaiting triage Needs triaging by team labels Nov 12, 2019
@NickColley
Copy link
Contributor

Is this relating to the SVG that already has [role="presentation"] on it? I wonder if [aria-hidden="true"] has the same issue.

@36degrees
Copy link
Contributor Author

As per the original comment, I think this might relate to the fallback png image. We'd need to do a bit of investigating to know for sure.

@kellylee-gds kellylee-gds added 🕔 hours A well understood issue which we expect to take less than a day to resolve. 🔍 investigation Priority: low and removed awaiting triage Needs triaging by team labels Nov 13, 2019
@NickColley NickColley assigned NickColley and unassigned NickColley Feb 5, 2020
@NickColley
Copy link
Contributor

It seems to be an accessibility feature on Chrome since you can right click then 'Get image descriptions from Google > Always | Just once'

When pressing 'just once'.

Now when I visit the logo it says the same message but 'Getting description...', but never succeeds.

When putting an empty alt attribute on the fallback image it stops the image from being detected for a description.

Changing role=presentation to aria-hidden=true also stops the image from being detected for a description.

My suggestion would be to always use aria-hidden=true when we intend for something to be removed from the accessibility tree as it also stops the children of the element from being shown.

@NickColley
Copy link
Contributor

Here is the feature explained: https://support.google.com/chrome/answer/9311597?hl=en

@NickColley
Copy link
Contributor

Using aria-hidden="true" will completely remove all elements, child elements, and content from the accessibility tree regardless of the default semantic nature and they will remain removed until the aria state is changed to false it functions in much the same way as CSS’s display:none. This is where it differs from role="presentation".

https://timwright.org/blog/2016/11/19/difference-rolepresentation-aria-hiddentrue/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve. 🔍 investigation
Projects
Development

Successfully merging a pull request may close this issue.

3 participants