From 7bba7da5f126b06425a5059e312385ea2d149e19 Mon Sep 17 00:00:00 2001 From: alex-ju Date: Thu, 19 Jul 2018 13:22:26 +0100 Subject: [PATCH 1/2] Use get-function to call Sass functions --- src/tools/_font-url.scss | 2 +- src/tools/_image-url.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tools/_font-url.scss b/src/tools/_font-url.scss index 5f8e92cad6..c21d994d0d 100644 --- a/src/tools/_font-url.scss +++ b/src/tools/_font-url.scss @@ -21,7 +21,7 @@ and function-exists($govuk-font-url-function); @if ($use-custom-function) { - @return call($govuk-font-url-function, $filename); + @return call(get-function($govuk-font-url-function), $filename); } @else { @return url($govuk-fonts-path + $filename); } diff --git a/src/tools/_image-url.scss b/src/tools/_image-url.scss index 7689b7e200..3672ac7aa4 100644 --- a/src/tools/_image-url.scss +++ b/src/tools/_image-url.scss @@ -21,7 +21,7 @@ and function-exists($govuk-image-url-function); @if ($use-custom-function) { - @return call($govuk-image-url-function, $filename); + @return call(get-function($govuk-image-url-function), $filename); } @else { @return url($govuk-images-path + $filename); } From e383738eb0d7dcb1388765d109559fcd45ab09c8 Mon Sep 17 00:00:00 2001 From: alex-ju Date: Thu, 19 Jul 2018 13:33:53 +0100 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8daddaa065..e2c47f7fbf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,9 @@ - Replace conflicting `js-hidden` class used within the tabs component with a new modifier class. Because this class is defined and used within the JavaScript, no markup changes are required. ([PR #916](https://github.com/alphagov/govuk-frontend/pull/916)) +- Use `get-function` when calling a Sass function as passing a string to `call()`` + is deprecated and will be illegal in Sass 4.0 + ([PR #919](https://github.com/alphagov/govuk-frontend/pull/919)) ## 1.1.1 (fix release)