-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form
not sent with same semantics as FormBody
#333
Comments
Some more info would be really helpful. Can you log the full bodies and do a diff there? |
I don't know where to capture the full body. Maybe I'll try some hardcore debugging later. |
OK I went hardcore, by placing a breakpoint deep within For example, base64 characters such as Note the headers are the same in both cases (in particular, Moreover, note that I cannot manually escape the content because it will encode |
See also amphp/http#24. |
I apologise I haven't been able to reduce this down to a simpler test case, but it seems very clear to me that something is not right when sending
Form
in beta 11 as withFormBody
from the previous API iteration. I haven't been able to narrow down exactly what is different between the two requests, but I can reliably reproduce it with a test.To test this, please try running
SteamLoginTest::testSecureLoginCookie
, which requiresSTEAM_USER
andSTEAM_PASSWORD
to be set to a valid Steam username and password (you can get an account for free).master
will work, but switching over toconnectors-v7
, which has minimal changes, will fail onSteamLogin:99
with{"response":{"interval":5,"extended_error_message":""}}
. Unfortunately this opaque error is all we have to work with.The text was updated successfully, but these errors were encountered: