New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnprocessedRequestException #337

Closed

kelunik opened this issue Jul 8, 2023 · 1 comment · Fixed by #349

Assignees

Milestone

Member

kelunik commented Jul 8, 2023

Work already started in #334.

kelunik self-assigned this

kelunik added this to the 5.x milestone

Member Author

kelunik commented Aug 23, 2023

@trowski I finally remember why we can remove this exception:

    /**
     * @return bool Whether processing the request has already been started.
     */
    public function isStarted(): bool
    {
        return EventInvoker::getPhase($this) !== Phase::Unprocessed;
    }

We have another way to check whether a request is unprocessed now.

kelunik linked a pull request

that will close this issue

Remove UnprocessedRequestException #349

Merged

kelunik closed this as completed in #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment