Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding Promise library #265

Closed
NotBobTheBuilder opened this issue Aug 13, 2016 · 4 comments
Closed

Allow overriding Promise library #265

NotBobTheBuilder opened this issue Aug 13, 2016 · 4 comments

Comments

@NotBobTheBuilder
Copy link

NotBobTheBuilder commented Aug 13, 2016

Currently the when Promise library is hardcoded. A useful feature might be to allow overriding this when requiring, in case the implementer has a preference for another promise library.

For example, the pg-promise library achieves this with the pattern: require('pg-promise')({promiseLib: require('bluebird')})

@p-bakker
Copy link

p-bakker commented Apr 2, 2019

Also an issue with the dependency on Bluebird, as Bluebird doesn't support async_hooks in NodeJS, which results in amqplib not supporting async_hooks

@xenoterracide
Copy link

really want this so we only need native promises, would a PR make it happen?

@Worthaboutapig
Copy link

I've done this and created a PR, though with a few caveats which shouldn't be a problem for most: #599

@cressie176
Copy link
Collaborator

I'm going to close this in favour of just using native promises #627.

Thanks for the PR @Worthaboutapig, and sorry it didn't get reviewed. I took a quick look just now and it includes a few unrelated changes (typescript defs, linting, plus maybe some dependency bumps), so I wouldn't want to merge. It will be useful as a reference point though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants