Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Format: MUI #943

Open
qweliant opened this issue Feb 22, 2023 · 1 comment
Open

Request for Format: MUI #943

qweliant opened this issue Feb 22, 2023 · 1 comment

Comments

@qweliant
Copy link

Format Proposal

i, and a few others:

https://github.com/mui/hackathon-figma-plugin/tree/857f5d48aeb108525293fbce490710051260e8d1/src
#927
mui/mui-design-kits#10
mui/mui-design-kits#26 (comment)

are trying to solve taking tokens from Figma and making meaningful representations in code by editing some exported token file with regards to MUI specifically.

i believe most are going to find issues with registering the appropriate format for mui typography variables.

some have successfully done this. though with the caveat of needing to register a custom format for MUI. but this is very close to something i would like to do.

As i work on a tokens->code workflow, this all makes me question whether we could get MUI var formats in SD

p.s. I suppose i also question whether this is a slippery slope for SD devs, bc i mean one could just always extend formats(is this true) to support some component library

@dbanksdesign
Copy link
Member

Yes you can can extend formats, or any other functionality (transforms, parsers, etc.). I think this would be a really good use-case of building a separate NPM package that exposes the right functionality to take in a tokens file from Figma Tokens and outputs a valid MUI theme. I wrote this RFC a while ago, it works as-is so anyone could write a plugin in this way today: #311

Also marking this as a duplicate of #927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants