Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small torrents with sparse seeding not completing #934

Open
mh0lt opened this issue Apr 22, 2024 · 4 comments
Open

Small torrents with sparse seeding not completing #934

mh0lt opened this issue Apr 22, 2024 · 4 comments

Comments

@mh0lt
Copy link
Contributor

mh0lt commented Apr 22, 2024

On testing the latest releases of Erigon over the past few months we've noticed that it's download phase, which downloads historic blockchain state across bittorrent stops at 99.999% complete.

We've discovered this is becuase a number 1-6 small torrents which have data on webseeds but not many torrent peers stop indefinately and hence prevent the completion of the torrent download.

We're building with v1.54.1 and go 1.20.

On investigation I've discovered that the torrents that don't download are ignoring their webseeds on initial download and becuase the webseeds never retry getting requests they will remain failed forever.

I have added a PR #932 to the mater branch which fixes this.

I have tested with a local patch of v1.54.1 and this seems to fix the issue.

I've noticed that the current master is building with go 1.22 and also has changes for V2 bittorrent which mean an interface change.

Ideally it would be great for us if this change could be merged to 1.54 or 1.55 so we can have a non breaking fix.

@anacrolix
Copy link
Owner

I thought there was a fix for something related to webseeding on master. Have you had a chance to try master for this problem?

@anacrolix
Copy link
Owner

See 528c5f6. Is it related at all?

@anacrolix
Copy link
Owner

I think it wasn't. I've commented on the PR for clarification.

@anacrolix
Copy link
Owner

I just closed 2 related PRs (noting that I cherry picked a bunch of stuff). From reading here it would seem maybe I didn't include the specific fixes you wanted however. Is that the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants