Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 14 support #456

Open
1 of 3 tasks
Quentigus opened this issue Aug 8, 2022 · 6 comments
Open
1 of 3 tasks

Angular 14 support #456

Quentigus opened this issue Aug 8, 2022 · 6 comments

Comments

@Quentigus
Copy link

I'm submitting a ...

  • bug report

  • feature request

  • question about the decisions made in the repository

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

  • What is the expected behavior? Upgrade angulartics to Angular 14

  • What is the motivation / use case for changing the behavior?

  • Environment: Enterprise

please run the following and copy the output

./node_modules/.bin/ng --version

Angular CLI: 14.1.0
Node: 14.17.0
Package Manager: npm 6.14.13

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1401.0
@angular-devkit/build-angular   14.1.0
@angular-devkit/core            14.1.0
@angular-devkit/schematics      14.1.0
@schematics/angular             14.1.0
ng-packagr                      14.1.0
rxjs                            7.5.6
typescript                      4.7.4
@sambernet
Copy link

Any update on angular 14 support, now that angular 15 is out for a month? 😁

Should we fork and provide a PR? Or is anybody working on that already?

@MrDWilson
Copy link

Also looking for this, wanting to update my app to Angular 15 and this is blocking now.

@shp-odoo
Copy link

shp-odoo commented Sep 7, 2023

is anybody working on that already as angular 16 is out now and it doesn't even support angular 14?

@sambernet
Copy link

sambernet commented Oct 30, 2023

Thanks to @rnsoon for providing PR #475 and for @scttcper for merging it.

But unfortunately there's still a few problems with it. Because this issue wasn't actually finished, I'll just comment that here in trying to get this forward. In fact, we are looking for angular 16 support, before 17 will be released soon - so let's try to clean up loose ends here first before starting over with those 🙈

Pending issues for ng14 support

  • the semantic-release job failed after merging due to a misconfiguration in the package.json:
    • release job run (github action): https://github.com/angulartics/angulartics2/actions/runs/6342059713
    • error message running the build step of the release job, which is an ng-packagr command:
      ng-packagr -p src/lib/package.json
      Building Angular Package
      Configuration doesn't match the required schema.
      Data path "" must NOT have additional properties (name).
      error Command failed with exit code 1.
      info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
      Error: Process completed with exit code 1.
      
    • it looks like this is just due to incorrectly placed ng-packagr configuration location in the package.json. This way of providing ng-packagr configuration within an ngPackage property in the package.json was valid with the previous versions up to v13, but is a breaking change in the migration to v14. The CHANGELOG states:

      package.json is not longer a valid method to configure ng-packagr. Use ng-package.json instead.

      • moving those settings into an extra ng-package.json file should be enough to fix this, and get the v14 release built.
  • the README.md wasn't updated to list the new version in the angular compatibility table. Or is this typically done after semantic-release has been performed, on main branch @scttcper?

Should I try to come up with an MR for this, or do you want to follow up with this @rnsoon ?

@scttcper
Copy link
Collaborator

scttcper commented Nov 1, 2023

@sambernet yeah if you have time to make a pull request

@rnsoon
Copy link
Contributor

rnsoon commented Dec 4, 2023

@sambernet apologies for the belated response. i'm doing a PR on the ng-package fix.
@scttcper re README, should i update the compatibility table to angular 14? or you prefer doing it after creating the ngx14 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants