From 8c27bc30d2f99a871f370a240c6d2651e78a1847 Mon Sep 17 00:00:00 2001 From: Pulkit Jain Date: Mon, 17 Oct 2022 10:23:01 +0530 Subject: [PATCH] Added Unit Tests Added unit tests to imporove the UT coverage for pkg/antctl/raw/set package. Signed-off-by: Pulkit Jain --- pkg/antctl/raw/set/command.go | 2 +- .../command.go | 2 +- .../raw/set/flowaggregator/command_test.go | 199 ++++++++++++++++++ 3 files changed, 201 insertions(+), 2 deletions(-) rename pkg/antctl/raw/set/{flow-aggregator => flowaggregator}/command.go (99%) create mode 100644 pkg/antctl/raw/set/flowaggregator/command_test.go diff --git a/pkg/antctl/raw/set/command.go b/pkg/antctl/raw/set/command.go index 00efd5a80c2..c6166ce33d5 100644 --- a/pkg/antctl/raw/set/command.go +++ b/pkg/antctl/raw/set/command.go @@ -17,7 +17,7 @@ package set import ( "github.com/spf13/cobra" - flow_aggregator "antrea.io/antrea/pkg/antctl/raw/set/flow-aggregator" + flow_aggregator "antrea.io/antrea/pkg/antctl/raw/set/flowaggregator" ) var SetCmd = &cobra.Command{ diff --git a/pkg/antctl/raw/set/flow-aggregator/command.go b/pkg/antctl/raw/set/flowaggregator/command.go similarity index 99% rename from pkg/antctl/raw/set/flow-aggregator/command.go rename to pkg/antctl/raw/set/flowaggregator/command.go index 5d3bf0a23de..a3a799df5a5 100644 --- a/pkg/antctl/raw/set/flow-aggregator/command.go +++ b/pkg/antctl/raw/set/flowaggregator/command.go @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package flow_aggregator +package flowaggregator import ( "context" diff --git a/pkg/antctl/raw/set/flowaggregator/command_test.go b/pkg/antctl/raw/set/flowaggregator/command_test.go new file mode 100644 index 00000000000..69c7e11065c --- /dev/null +++ b/pkg/antctl/raw/set/flowaggregator/command_test.go @@ -0,0 +1,199 @@ +// Copyright 2022 Antrea Authors +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package flowaggregator + +import ( + "context" + "fmt" + "log" + "os" + "testing" + + "github.com/stretchr/testify/assert" + corev1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + testclient "k8s.io/client-go/kubernetes/fake" +) + +func TestUpdateRunE(t *testing.T) { + cmd := NewFlowAggregatorSetCommand() + var args []string + err := updateRunE(cmd, args) + assert.Error(t, err) + + tcs := []struct { + fakeConfigs []byte + }{ + { + fakeConfigs: []byte(`apiVersion: v1 +clusters: +- cluster: + certificate-authority-data: data + server: https://localhost + name: fake-cluster +contexts: +- context: + cluster: fake-cluster + user: user-id + name: fake-cluster +current-context: fake-cluster +kind: Config`), + }, + { + fakeConfigs: []byte(`apiVersion: v1 +clusters: +- cluster: + certificate-authority-data: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURJVENDQWdtZ0F3SUJBZ0lJTHJac3Z6ZFQ3ekF3RFFZSktvWklodmNOQVFFTEJRQXdGVEVUTUJFR0ExVUUKQXhNS2EzVmlaWEp1WlhSbGN6QWVGdzB5TWpBNE1qSXdNakl6TXpkYUZ3MHlNekE0TWpJd01qSXpNemxhTURReApGekFWQmdOVkJBb1REbk41YzNSbGJUcHRZWE4wWlhKek1Sa3dGd1lEVlFRREV4QnJkV0psY201bGRHVnpMV0ZrCmJXbHVNSUlCSWpBTkJna3Foa2lHOXcwQkFRRUZBQU9DQVE4QU1JSUJDZ0tDQVFFQTB4N2JEd2NqSzN3VjRGSzkKYUtrd0FUdjVoT2NsbHhUSEI1ejFUbHZJV3pmdTNYNjZtaWkxUE04ODI1dTArdDRRdisxUVRIRHFzUkNvWFA1awpuNGNWZkxkeTlad25uN01uSDExVTRsRWRoeXBrdlZsc0RmajlBdWh3WHBZVE82eE5kM2o2Y3BIZGNMOW9PbGw2CkowcGU2RzBleHpTSHMvbHRUZXlyalRGbXM2Sm5zSWV6T2lHRmhZOTJCbDBmZ1krb2p6MFEwM2cvcE5QZUszcGMKK05wTWh4eG1UY1lVNzlaZVRqV1JPYTFQSituNk1SMEhDbW0xQk5QNmdwWmozbGtWSktkZnBEYmovWHYvQWNkVQpab3E5Ym95aGNDUCtiYmgyaWVtaTc0bnZqZ1BUTkVDZWU2a3ZHY3VNaXRKUkdvWjBxbFpZbXZDaWdEeGlSTnBNClBPa1dud0lEQVFBQm8xWXdWREFPQmdOVkhROEJBZjhFQkFNQ0JhQXdFd1lEVlIwbEJBd3dDZ1lJS3dZQkJRVUgKQXdJd0RBWURWUjBUQVFIL0JBSXdBREFmQmdOVkhTTUVHREFXZ0JSc2VoZXVkM0l5VWRNdkhhRS9YU3MrOFErLwpiVEFOQmdrcWhraUc5dzBCQVFzRkFBT0NBUUVBcmg4UFRadFgvWjlHVzlMYmxZZ1FWWE04VlRrWEtGSEpTZldOCkJLNXo2NWNWdGN2cFZ0WDZNTlppTFhuYkFzQ0JPY1RqejBJRlphYkNNUkZzYmdYbEVqV0ZuRE5abzBMVHFTZUcKQ2RqTWljK0JzbmFGUThZOXJ5TTVxZ0RhQzNWQkdTSXVscklXeGxPYmRmUEpWRnpUaVNTcmJBR1Z3Uk5sQlpmYgpYOXBlRlpNNmNFNUhTOE5RTmNoZkh2SWhGSUVuR2YxOUx2enp0WGUzQWwwb3hYNjdRKzhyWXd0Tm56dS9xM29BCmJIN1dsNld5ODVYNS90RWlQcWU0ZU1GalRDME9tR2NHZ2lQdU90NjlIejAwV2hvaWNYYWpma1FZOHNKMk5Uc1cKdUcxbWZqb0tTdUN0OC9BRmhPNURlaHZ3eFNIQU12eG1VQUJYL294bU1DNzdwV0VnRWc9PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg== + server: https://localhost + name: fake-cluster +contexts: +- context: + cluster: fake-cluster + user: user-id + name: fake-cluster +current-context: fake-cluster +kind: Config`), + }, + } + + for _, tc := range tcs { + fakeKubeconfig, err := os.CreateTemp("", "fakeKubeconfig") + if err != nil { + log.Fatal(err) + } + defer os.Remove(fakeKubeconfig.Name()) + fakeKubeconfig.Write(tc.fakeConfigs) + if cmd.Flag("kubeconfig") != nil { + cmd.Flag("kubeconfig").Value.Set(fakeKubeconfig.Name()) + } else { + cmd.Flags().String("kubeconfig", fakeKubeconfig.Name(), "path of kubeconfig") + } + err = updateRunE(cmd, args) + assert.Error(t, err) + } +} + +func TestSetBoolOrFail(t *testing.T) { + tcs := []struct { + b bool + value string + errorExpected bool + }{ + { + value: "1", + errorExpected: false, + }, + { + value: "tt", + errorExpected: true, + }, + } + + for _, tc := range tcs { + err := setBoolOrFail(&tc.b, tc.value) + if tc.errorExpected { + assert.Error(t, err) + } else { + assert.NoError(t, err) + } + } +} + +func TestSetStringOrFail(t *testing.T) { + tc := []struct { + b string + value string + }{ + { + value: "11mm", + }, + } + + _ = setStringOrFail(&tc[0].b, tc[0].value) + assert.Equal(t, tc[0].b, tc[0].value) +} + +func TestSetCommitIntervalOrFail(t *testing.T) { + tcs := []struct { + b string + value string + errorExpected bool + }{ + { + value: "1m25s", + errorExpected: false, + }, + { + value: "0.5s", + errorExpected: true, + }, + { + value: "0.5ss", + errorExpected: true, + }, + } + + for _, tc := range tcs { + err := setCommitIntervalOrFail(&tc.b, tc.value) + if tc.errorExpected { + assert.Error(t, err) + } else { + assert.Equal(t, tc.b, tc.value) + } + } +} + +func TestGetFAConfigMap(t *testing.T) { + k8sClient := testclient.NewSimpleClientset() + tcs := []struct { + faConfigMap *corev1.ConfigMap + errorExpected bool + }{ + { + faConfigMap: &corev1.ConfigMap{ + ObjectMeta: metav1.ObjectMeta{ + Name: "testConfigMap", + Namespace: "flow-aggregator", + }, + }, + errorExpected: false, + }, + { + faConfigMap: &corev1.ConfigMap{ + ObjectMeta: metav1.ObjectMeta{ + Name: "", + Namespace: "flow-aggregator", + }, + }, + errorExpected: true, + }, + } + + for _, tc := range tcs { + _, err := k8sClient.CoreV1().ConfigMaps("flow-aggregator").Create(context.TODO(), tc.faConfigMap, metav1.CreateOptions{}) + if err != nil { + fmt.Println(err) + } + configMap, err := GetFAConfigMap(k8sClient, tc.faConfigMap.Name) + if tc.errorExpected { + assert.Error(t, err) + } else { + assert.Equal(t, tc.faConfigMap, configMap) + } + } + + result, _ := GetFAConfigMap(k8sClient, "testConfigMap1") + assert.Nil(t, result) +}