Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo -Wrapper typo] typo #2811

Closed
2 tasks done
zonghaishang opened this issue Nov 21, 2018 · 1 comment
Closed
2 tasks done

[Dubbo -Wrapper typo] typo #2811

zonghaishang opened this issue Nov 21, 2018 · 1 comment

Comments

@zonghaishang
Copy link
Member

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.0+
  • Operating System version: mac
  • Java version: 1.8

com.alibaba.dubbo.common.bytecode.Wrapper#makeWrapper:

c2.append(" throw new " + NoSuchPropertyException.class.getName() + "(\"Not found property \\\"\"+$2+\"\\\" filed or setter method in class " + c.getName() + ".\"); }");

should be changed to

c2.append(" throw new " + NoSuchPropertyException.class.getName() + "(\"Not found property \\\"\"+$2+\"\\\" filed or getter method in class " + c.getName() + ".\"); }");

c2 represents the read value attribute.

StringBuilder c2 = new StringBuilder("public Object getPropertyValue(Object o, String n){ ");
@htynkn
Copy link
Member

htynkn commented Nov 24, 2018

I think this is fixed by #2825

@htynkn htynkn closed this as completed Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants