From c660773e9fb4a4a88fe5f982eaac55da0d422902 Mon Sep 17 00:00:00 2001 From: Diego Medina Date: Mon, 6 Feb 2023 22:46:43 -0300 Subject: [PATCH] PR comments --- docs/static/resources/openapi.json | 42 ------------------------------ superset/sqllab/schemas.py | 10 ++++--- 2 files changed, 6 insertions(+), 46 deletions(-) diff --git a/docs/static/resources/openapi.json b/docs/static/resources/openapi.json index 207a45dcf51df..ba5e46a4bf14d 100644 --- a/docs/static/resources/openapi.json +++ b/docs/static/resources/openapi.json @@ -1955,27 +1955,6 @@ ], "type": "object" }, - "ChartDataRestApi.get_list.User2": { - "properties": { - "first_name": { - "maxLength": 64, - "type": "string" - }, - "id": { - "format": "int32", - "type": "integer" - }, - "last_name": { - "maxLength": 64, - "type": "string" - } - }, - "required": [ - "first_name", - "last_name" - ], - "type": "object" - }, "ChartDataRestApi.get_list.User3": { "properties": { "first_name": { @@ -2764,27 +2743,6 @@ ], "type": "object" }, - "ChartRestApi.get_list.User2": { - "properties": { - "first_name": { - "maxLength": 64, - "type": "string" - }, - "id": { - "format": "int32", - "type": "integer" - }, - "last_name": { - "maxLength": 64, - "type": "string" - } - }, - "required": [ - "first_name", - "last_name" - ], - "type": "object" - }, "ChartRestApi.get_list.User3": { "properties": { "first_name": { diff --git a/superset/sqllab/schemas.py b/superset/sqllab/schemas.py index d146558c5652a..134b9ea7bb799 100644 --- a/superset/sqllab/schemas.py +++ b/superset/sqllab/schemas.py @@ -26,10 +26,12 @@ class EstimateQueryCostSchema(Schema): - database_id = fields.Integer(required=True) - sql = fields.String(required=True) - template_params = fields.Dict(keys=fields.String()) - schema = fields.String(allow_none=True) + database_id = fields.Integer(required=True, description="The database id") + sql = fields.String(required=True, description="The SQL query to estimate") + template_params = fields.Dict( + keys=fields.String(), description="The SQL query template params" + ) + schema = fields.String(allow_none=True, description="The database schema") class ExecutePayloadSchema(Schema):