Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[list_view] Unify Forbidden behavior for removing and editing datasets #12494

Closed
3 tasks
adam-stasiak opened this issue Jan 13, 2021 · 1 comment
Closed
3 tasks
Labels
enhancement:request Enhancement request submitted by anyone from the community need:design-review Requires input/approval from a Designer

Comments

@adam-stasiak
Copy link
Contributor

In #12491 we are introducing popup for forbidden behavior when user tries to modify dataset. We should keep this way also for removal of datasets.

Expected results

When I try to remove dataset - I can see popup

Actual results

When I try to remove dataset - I see a toast

Screenshots

image
image

How to reproduce the bug

Login as admin
add 2 users with alpha permission
As user 1 add dataset
As user 2 try to remove dataset

Environment

(please complete the following information):

docker - commit 0ae16bf

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

@adam-stasiak adam-stasiak added the #bug Bug report label Jan 13, 2021
@junlincc junlincc added enhancement:request Enhancement request submitted by anyone from the community need:design-review Requires input/approval from a Designer and removed #bug Bug report Polidea labels Jan 13, 2021
@Steejay
Copy link

Steejay commented Jan 14, 2021

hey @adam-stasiak I think we could avoid having users encountering this decision by stopping them earlier in the flow. We suggest disabling the edit and delete icon in the actions column. When a user hovers over the disabled icon, a tooltip would appear describing why this action is disabled.

delete tooltip:
"You do not have permission to delete this (object)."

edit tooltip:
"You do not have permission to edit this (object)."

Generally we should avoid modal on modal situations. If this were something like an API error then the toast might be a better solution given the existing modal.

cc @rusackas @mihir174

@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18428 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement:request Enhancement request submitted by anyone from the community need:design-review Requires input/approval from a Designer
Projects
None yet
Development

No branches or pull requests

3 participants