Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sqllab] results table overlap buttons, horizontal scroll doesn't work when column is 50+ #12538

Closed
3 tasks done
michellethomas opened this issue Jan 15, 2021 · 3 comments
Closed
3 tasks done
Assignees
Labels
#bug Bug report P2 Priority item - High sqllab Namespace | Anything related to the SQL Lab

Comments

@michellethomas
Copy link
Contributor

If you run a query in sqllab that returns a large number of columns, the results header shows up on top of the "explore" and "csv" buttons making them not clickable.

Screenshots

image (4)

How to reproduce the bug

  1. Run a select * statement on a table with 70+ columns
  2. Results header will show up on top of the action buttons and you cannot click on the buttons

Environment

  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@michellethomas michellethomas added sqllab Namespace | Anything related to the SQL Lab #bug Bug report labels Jan 15, 2021
@junlincc junlincc added the P1 Priority item - Major label Jan 15, 2021
@junlincc junlincc changed the title Sqllab results header blocks "explore" and "csv" buttons for results with large number of columns [Sqllab] results table overlap buttons, scroll doesn't work when column is 50+ Jan 15, 2021
@junlincc junlincc changed the title [Sqllab] results table overlap buttons, scroll doesn't work when column is 50+ [Sqllab] results table overlap buttons, horizontal scroll doesn't work when column is 50+ Jan 15, 2021
@junlincc
Copy link
Member

Screen Shot 2021-01-15 at 10 10 13 AM

@junlincc junlincc added P2 Priority item - High and removed P1 Priority item - Major labels Jan 15, 2021
@betodealmeida betodealmeida self-assigned this Jan 15, 2021
@betodealmeida
Copy link
Member

Let me take a look, I worked on the height of the results recently and might've broken this.

@betodealmeida
Copy link
Member

Looks like it happen when have more than MAX_COLUMNS_FOR_TABLE columns (which defaults to 50), and we invoke renderGrid in FilterableTable.tsx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report P2 Priority item - High sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

No branches or pull requests

4 participants