Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Box Plot query generated wrongly breaking charts #12553

Closed
2 of 3 tasks
zuzana-vej opened this issue Jan 15, 2021 · 0 comments · Fixed by #12556
Closed
2 of 3 tasks

[charts] Box Plot query generated wrongly breaking charts #12553

zuzana-vej opened this issue Jan 15, 2021 · 0 comments · Fixed by #12556
Assignees
Labels
#bug:regression Bugs that are identified as regessions P0 Priority item - Critical viz:charts:boxplot Related to the Boxplot chart

Comments

@zuzana-vej
Copy link
Contributor

zuzana-vej commented Jan 15, 2021

After the new explore redesign, the query generated for Box Plot chart is wrong, cause the chart to error out. The GROUP BY statement in missing in the query. The query should group by SERIES and by DISTRIBUTE ACROSS fields.

Expected results

Query gets composed correctly so that chart works

Actual results

Query is composed wrongly, chart errors out

Screenshots

Error:
Error: {'message': 'line 1:8: \'"entity_type"\' must be an aggregate expression or appear in GROUP BY clause', 'errorCode': 73, 'errorName': 'EXPRESSION_NOT_AGGREGATE',

Generated query resulting in error:
Screen Shot 2021-01-15 at 9 37 09 AM

Same query with added GROUP BY working in SQL Lab:
Screen Shot 2021-01-15 at 9 40 52 AM

How to reproduce the bug

  1. Go to Explore, create chart for Box Plot
  2. Select field in "SERIES" and "DISTRIBUTE ACROSS"
  3. Run chart and see error - group by wasn't added into the query statement

Environment

master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

There is no workaround. Any Box plot chart which had the SERIES or DISTRIBUTE ACROSS specified is broken.

@zuzana-vej zuzana-vej added #bug Bug report #bug:regression Bugs that are identified as regessions P0 Priority item - Critical viz:charts:boxplot Related to the Boxplot chart labels Jan 15, 2021
@junlincc junlincc removed the #bug Bug report label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions P0 Priority item - Critical viz:charts:boxplot Related to the Boxplot chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants