Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore]chart missing dataset open error msg #12753

Closed
junlincc opened this issue Jan 26, 2021 · 5 comments
Closed

[explore]chart missing dataset open error msg #12753

junlincc opened this issue Jan 26, 2021 · 5 comments
Labels
design:proposal Design proposals explore:dataset Related to the dataset of Explore inactive Inactive for >= 30 days

Comments

@junlincc
Copy link
Member

junlincc commented Jan 26, 2021

We want to make sure PRs that introduce UI changes from the community are always welcome without follow strict guideline when they are first created. Design support will follow after these PRs are open if we can't provide Product and Design support upfront. tagging design-sys-revisit to track and prevent system level design debt.

image

#12705

'@junlincc @mihir174 feel free to create another issue to track followups if you want to update the design or copy.'
'A possible followup would be to add "Delete chart" shortcut CTA to make it easier for chart owners to delete outdated charts.'

@junlincc junlincc added design-sys-revisit explore:dataset Related to the dataset of Explore labels Jan 26, 2021
@junlincc
Copy link
Member Author

@ktmud @mistercrunch FYI ^ above is a temporary solution for balancing velocity and design quality, and for keeping OSS product development process transparent and open in the community.

@mistercrunch
Copy link
Member

@junlincc I like it.

Seems like the "CHANGE DATASET" button should be styled in orange/warning too to avoid blue-on-orange

@geido
Copy link
Member

geido commented Feb 3, 2022

We are cleaning up the labels and trying to reduce the amount. I believe need:design-review is appropriate and generic enough to catch PRs and issues that require design consideration, while design:proposal is appropriate for design proposals from the community.

@geido geido added design:proposal Design proposals and removed revisit:design-sys labels Feb 3, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 16, 2022
@rusackas
Copy link
Member

Much of this flow has been redesigned/re-engineered since this was open, and I believe the issue has been largely addressed. If there are nuances to the new flow that are perceived as bugs, or need hashing out as a design/feature discussion, let's open fresh Issues and Github Discussions accordingly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:proposal Design proposals explore:dataset Related to the dataset of Explore inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

4 participants