Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[color theme] stacked bar chart with 'Superset color' theme will change color when save to dashboard #16891

Closed
2 of 3 tasks
jinghua-qa opened this issue Sep 29, 2021 · 5 comments · Fixed by #17089
Closed
2 of 3 tasks
Labels
#bug Bug report preset:QA Preset QA team

Comments

@jinghua-qa
Copy link
Member

jinghua-qa commented Sep 29, 2021

stacked bar chart with superset color theme will change color (within the same color theme) when save to dashboard

How to reproduce the bug

  1. Go to a chart, pie chart or bar chart from example charts
  2. Click on CUSTOMIZE panel and select 'Superset color theme'
  3. Save the chart with superset color theme to dashboard
  4. See error

Expected results

When save chart to dashboard, chart color did not change

Actual results

When save chart to dashboard, chart color changed to other color within the same color theme

Screenshots

Screen.Recording.2021-09-29.at.12.46.49.AM.mov

Environment

(please complete the following information):

  • browser type and version: Chrome
  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@jinghua-qa jinghua-qa added the #bug Bug report label Sep 29, 2021
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Sep 29, 2021
@jinghua-qa jinghua-qa changed the title [color theme] charts with 'Superset color' theme will change color when save to dashboard [color theme] stacked bar charts with 'Superset color' theme will change color when save to dashboard Sep 29, 2021
@jinghua-qa jinghua-qa changed the title [color theme] stacked bar charts with 'Superset color' theme will change color when save to dashboard [color theme] stacked bar chart with 'Superset color' theme will change color when save to dashboard Sep 29, 2021
@jinghua-qa
Copy link
Member Author

This issue also seen in pie chart

@geido
Copy link
Member

geido commented Sep 29, 2021

@jinghua-qa my observation is that this issue affects all the charts not any chart in particular

@jinghua-qa
Copy link
Member Author

jinghua-qa commented Oct 1, 2021

It looks to me bar and area chart are the most inconsistent ones amount popular charts, when add bar chart and area chart to dashboard the color change. I think i saw pie chart but i can not repro now.
Screen Shot 2021-10-01 at 1 36 28 AM
Screen Shot 2021-10-01 at 1 39 42 AM

@geido
Copy link
Member

geido commented Oct 1, 2021

I was sure to see the issue affecting most of the charts. When saving the chart again after having added it to the dashboard, the color was changing. However, I cannot reproduce it now and after re-testing, it seems to work fine now for the charts that I tested so far.

@zakaryanla
Copy link

Actual for 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report preset:QA Preset QA team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants