Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-81] Set default user to the first owner of its alert(report) schedule prior to the 'THUMBNAIL_SELENIUM_USER' value in config #19693

Closed
jileeon opened this issue Apr 13, 2022 · 3 comments
Labels
sip Superset Improvement Proposal

Comments

@jileeon
Copy link
Contributor

jileeon commented Apr 13, 2022

Motivation

When an alert or a report is sent by schedule, its data depends on the 'THUMBNAIL_SELENIUM_USER' value in config.
so we can't apply RLS(Row Level Security) for a specific purpose.

Proposed Change

If an operator sets the 'THUMBNAIL_SELENIUM_USER' to None in superset_config.py, the user will be set as the first owner of its alert(report) schedule for sending an alert(or a report) by default.

New or Changed Public Interfaces

No - As far as I know...

New dependencies

N/A

Migration Plan and Compatibility

N/A

Rejected Alternatives

Improve 'Notification Method'(in a schedule setting) can support like 'Login as' feature. so just one schedule setting covers sending multiple reports with different RLS. In this case, we also have to think about the security problem.(which user can be set as a 'login as' and is it valid.)

@jileeon
Copy link
Contributor Author

jileeon commented Apr 13, 2022

I confirmed 'EMAIL_REPORTS_USER' will be no longer exists in apache-superset 2.0.0. (in 0968f86).

So changing the code related to 'THUMBNAIL_SELENIUM_USER' to achieve this.

@rusackas
Copy link
Member

Sounds like this is a done deal then? Closing it out, but happy to revisit/reopen if I'm misconstruing things.

@jileeon
Copy link
Contributor Author

jileeon commented Mar 13, 2023

@rusackas, This pull request(#21931) includes what I wanted.

It's a done deal finally.

Thanks.

@rusackas rusackas added the sip Superset Improvement Proposal label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sip Superset Improvement Proposal
Projects
Status: Denied / Closed / Discarded
Development

No branches or pull requests

2 participants