Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmetic][sql lab] When user did not set limit the query the yellow banner for limit is off #25288

Closed
3 tasks
jinghua-qa opened this issue Sep 13, 2023 · 1 comment
Assignees

Comments

@jinghua-qa
Copy link
Member

if user did not have limit or select limit in the query, a yellow card of limit msg will show, but with the new feature, the card position seems off

How to reproduce the bug

  1. Go to sql, run query without selecting the limit or set limit in query
  2. Run query
  3. Observe the the result section
  4. See the yellow banner is to the right side of the query

Expected results

the yellow banner should be in the center

what you expected to happen.

Actual results

Yellow banner is on the side and user is hard to read the msg

Screenshots

Screen Shot 2023-09-13 at 7 56 56 AM

Environment

(please complete the following information):

  • browser type and version:
  • superset version: superset version
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@rusackas
Copy link
Member

Seems like this was fixed but never closed. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants