Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: missing terms in french #25728

Closed
3 tasks
cchristofr opened this issue Oct 20, 2023 · 8 comments · Fixed by #26074
Closed
3 tasks

Translation: missing terms in french #25728

cchristofr opened this issue Oct 20, 2023 · 8 comments · Fixed by #26074

Comments

@cchristofr
Copy link

Some terms are not translated in the UI

How to reproduce the bug

  1. Open a dashboard
  2. Click on ADD/EDIT Filters
  3. Add a Time range filter
  4. Filter has default value : Choose Last
  5. Choose 'Last quarter'
  6. Save

Expected results

The value of the filter should be "Le trimestre dernier"

Actual results

But it is "Last quarter"

The same for each period: "Last day" to ... "Last year" are not translated as value for the filter.

Screenshots

bug_french

Environment

(please complete the following information):

  • browser type and version:Firefox 118.0.2
  • superset version: 2.1.0
  • python version: 3.8.16
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@sfirke
Copy link
Member

sfirke commented Nov 9, 2023

This was fixed in #20078 🚀 Looks like that PR made it into 3.0.0. If you're able to upgrade to that version or 3.0.1 (the latest), you should see it. Please reply if that is not the case.

@sfirke sfirke closed this as completed Nov 9, 2023
@aehanno
Copy link
Contributor

aehanno commented Nov 15, 2023

HI @sfirke, I upgrade my version in 3.0.1 and when I choose French, I got all those string in English
Before my upgrade I got that
image
and now in 3.0.1, I have that
image

@sfirke
Copy link
Member

sfirke commented Nov 15, 2023

Hmmm. To confirm, you're showing the translation coverage got worse when you upgraded to 3.0.0/3.0.1 ?

@sfirke sfirke reopened this Nov 15, 2023
@aehanno
Copy link
Contributor

aehanno commented Nov 15, 2023

I was in 2.1.0, so an upgrade from 2.1.0 to 3.0.1

@aehanno
Copy link
Contributor

aehanno commented Nov 16, 2023

@sfirke and I just saw that there is custom and last that are not translate
But the other filter are correct
for the 3.0.1 version
image

@sfirke
Copy link
Member

sfirke commented Nov 16, 2023

Ah @aehanno I see you authored that PR I linked (thank you!) - are you able to create a PR to add this coverage?

@aehanno
Copy link
Contributor

aehanno commented Nov 17, 2023

@sfirke and @cchristofr
The PR #26010 fix regression but we still don't have the translation in the filter
It's a more complicated fix than just translation so I didn't found how to fix it

@Ralkion
Copy link
Contributor

Ralkion commented Nov 21, 2023

This seems related to #25994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants