Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset Row Limit - not updating in web ui #27115

Closed
3 tasks done
shubhshah01 opened this issue Feb 14, 2024 · 2 comments
Closed
3 tasks done

Superset Row Limit - not updating in web ui #27115

shubhshah01 opened this issue Feb 14, 2024 · 2 comments

Comments

@shubhshah01
Copy link

shubhshah01 commented Feb 14, 2024

Bug description

Even after setting ROW_LIMIT and SQL_MAX_ROW in the config file at /app/superset_config.py file the row limit is not increasing while creating charts.

SQL_MAX_ROW = 10000000
ROW_LIMIT = 10000000

How do i increase the row limit in superset ?

How to reproduce the bug

  1. add SQL_MAX_ROW = 10000000 and ROW_LIMIT = 10000000 in mounted config file or directly inside container at /app/superset_config.py file
  2. Go to Charts
  3. Create charts
  4. select any datasource and table chart
  5. select any dimension
  6. Scroll down and for ROW LIMIT dropdown enter 500000

Screenshots/recordings

image

Superset version

3.1.0

Python version

3.9

Node version

18 or greater

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@shubhshah01
Copy link
Author

Tried these config as well

# Custom (user) configuration below
SUPERSET_WEBSERVER_TIMEOUT = 600 # Increasing queries timeout
ROW_LIMIT = 1000000
SAMPLES_ROW_LIMIT = 50000000
FILTER_SELECT_ROW_LIMIT = 50000000
QUERY_SEARCH_LIMIT = 50000000
SQL_MAX_ROW = 500000000
DISPLAY_MAX_ROW = 50000000
DEFAULT_SQLLAB_LIMIT = 50000000

@michael-s-molina
Copy link
Member

Hi @shubhshah01. This was fixed by #26807 and it will be included in 3.1.1 which is currently being voted and should be available next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants