Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message "Action Required ..." always appearing in Explore Chart #9394

Closed
lilila opened this issue Mar 26, 2020 · 5 comments
Closed
Labels
inactive Inactive for >= 30 days

Comments

@lilila
Copy link

lilila commented Mar 26, 2020

The following message ("Action Required: Preview then save your chart using the ..." ) appears everytime Explore Chart view is open (pic1).
It appears for all roles (at leat for admin and public roles)

The same message also appears on "standalone" plots (pic2)

Screenshot 2020-03-26 at 10 42 29

Screenshot 2020-03-26 at 10 43 31

@villebro
Copy link
Member

@lilila I would recommend updating the charts to use the new time range endpoints, as they will replace the old format at some point. Would that be an option in this case?

@mistercrunch
Copy link
Member

Related: we need to upgrade the examples and re-think the design of the current solution around the time range filter control and its label. Also the term "endpoint" and the message here is confusing. @john-bodley

@john-bodley john-bodley mentioned this issue Mar 26, 2020
12 tasks
@john-bodley
Copy link
Member

@lilila just to clarify is then every time you explore a chart or every time you explore an existing chart for which the time range endpoints haven't been updated to be [start, end), i.e., inclusive of start and exclusive of end? Note that this message will persist until either:

  1. You preview and re-save the chart per the messaging.
  2. The grace period for manually updating your charts has ended per here. After which all charts will use the [start, end) interval.

@lilila
Copy link
Author

lilila commented Mar 27, 2020

Thank you @john-bodley , @mistercrunch, @villebro for your answers.
It was my fault, if I explore the chart first, save the new chart and then create the iframe the message does not appear anymore :D .

So it is fixed!

@stale
Copy link

stale bot commented May 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 29, 2020
@lilila lilila closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

4 participants