Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in segment_methods concern #1

Open
cbarrese opened this issue Mar 8, 2023 · 0 comments
Open

Possible bug in segment_methods concern #1

cbarrese opened this issue Mar 8, 2023 · 0 comments

Comments

@cbarrese
Copy link

cbarrese commented Mar 8, 2023

First I want to thank you for taking the time to release this publicly. I have been using it to create test NCPDP D.0 messages.

I believe the code at the following line will always fail since the initializer of DZero::Transmissions::Groups::TransactionGroup does not expect a hash, but instead keyword args.

https://github.com/apiv/dzero/blob/master/lib/dzero/transmissions/concerns/segments_methods.rb#L61

If I change that line to the following it no longer fails

transaction_groups << ::DZero::Transmissions::Groups::TransactionGroup.new(segments: [])

To reproduce, I believe all you need to do is include any segment that is not Patient or Insurance in the transmission request segments(Pricing for example).

A similar error is in the README request construction example. The request initializer is expecting keyword args and not a hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant