Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveAs is not defined #187

Closed
bcolucci opened this issue Mar 26, 2018 · 1 comment
Closed

saveAs is not defined #187

bcolucci opened this issue Mar 26, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@bcolucci
Copy link

Tell us where you are using Dejavu (Hosted web app, Chrome extension, Docker Image, Within appbase.io)

Local only, I'm trying to contribute.

What is the version of Dejavu that you are using?

I'm on the dev branch.


I've followed the contributor steps, ran the app, and when I've tried to click on one of the "Download as XXX" buttons, I have an error:

Uncaught ReferenceError: saveAs is not defined
    at o.downloadJSON (live.js:formatted:37013)
    at Object.r (live.js:formatted:6689)
    at i (live.js:formatted:6480)
    at Object.s [as executeDispatchesInOrder] (live.js:formatted:6488)
    at f (live.js:formatted:4304)
    at m (live.js:formatted:4311)
    at Array.forEach (<anonymous>)
    at r (live.js:formatted:9726)
    at Object.processEventQueue (live.js:formatted:4366)
    at r (live.js:formatted:20838)
o.downloadJSON = function() {
	var e = new File([o.props.dejavuExportData],"data.json",{
		type: "application/json;charset=utf-8"
	});
	saveAs(e)
}
@divyanshu013 divyanshu013 self-assigned this Apr 2, 2018
@divyanshu013 divyanshu013 added this to the 1.6.0 milestone Apr 2, 2018
@divyanshu013
Copy link
Contributor

After diving into this I realized the issue was caused due to the file-saver bower dependency we're using (reference). Seems like the bower distribution was empty in the recent package.

You can fix this by pulling the latest changes on dev and running bower install to resolve to the correct dependency. If it doesn't work, you might have to run bower cache clean and then run bower install again. Thanks for reporting, we'll roll this out in v1.6.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants