Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host dejavu at root path #210

Closed
siddharthlatest opened this issue May 15, 2018 · 1 comment
Closed

Host dejavu at root path #210

siddharthlatest opened this issue May 15, 2018 · 1 comment

Comments

@siddharthlatest
Copy link
Member

Tell us where you are using Dejavu (Hosted web app, Chrome extension, Docker Image, Within appbase.io)

All

What is the version of Dejavu that you are using?

Latest

Describe the issue that you are seeing, or the feature request :-), include any screenshots as necessary.

Currently, dejavu lives at /live endpoint. This creates a complexity on the user end if you were to host dejavu at a non-root domain, e.g. if dejavu resided inside of example.my-domain.com/dejavu path, it can be a bit complex to get the routing done in a generic fashion (since we ourselves do a redirect if a request comes at '/' to route to '/live'.

We can simplify this scenario (and possibly others) by simply putting dejavu at '/'.

@divyanshu013
Copy link
Contributor

@siddharthlatest we can now host dejavu at /. It'll also work at /live for backward compatibility (with some missing images). Before deploying we should set up the route redirection for old blog post or docs links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants