-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutation of returned _source data in results by highlightResults function #10
Comments
I agree, you have a point here. We only mutate the hits data in order to render the highlighted fields in the result-component directly. This lets users render highlighted results easily without worrying about processing the highlighted fields. But I believe, we should come up with an approach where either both of these behaviors are feasible by default or it is toggle-able. |
Left a pull request. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a user specifies they want their data to be highlighted the highlighted data returns a truncated portion in the _source.
Please see my comments below. I didn't think a pull request was appropriate as all I would be doing is deleting a function.
Is there a reason for mutating the source of the highlighted data?
Best,
Ryan
The text was updated successfully, but these errors were encountered: