-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataSearch component - controlled behaviour not working #2114
Comments
This is working correctly for the SearchBox component, so that is a fine alternative. Probably this can be closed if you prefer. Thanks! |
We have this issue as well. We want to use "DataSearch". Can it be fixed instead? |
@rs-unsilo Any reason to use DataSearch over SearchBox? |
We use a customQuery directly to an elastic endpoint. Is that possible with SearchBox? IE. connect directly to an elastic endpoint (via a local proxy). From documentation it sounds a lot more bothersome with having to use a third party service, etc. compared to DataSearch Regarding DataSearch - It must be a quite obvious bug to fix? triggeQuery() is called on every keystroke no matter how you set it up |
Affected Projects
React
Library Version: x.y.z
3.41.1 (working correctly in 3.0.0)
Describe the bug
When using the controlled behaviour of the DataSearch component to only trigger 'on enter' (as described here #994 (comment))
, query is triggered on every keypress.
To Reproduce
![Edit reactivesearch-quickstart-final-app (forked)](https://camo.githubusercontent.com/97cbe82b1619b42e1f78fce9db09104b932a9da1fd37751f4d9c41f4fe350241/68747470733a2f2f636f646573616e64626f782e696f2f7374617469632f696d672f706c61792d636f646573616e64626f782e737667)
Steps to reproduce the behavior:
Using above codesandbox:
Type in search box, query is made on every keypress.
Expected behavior
Type in search box, query is made only after key 'enter'.
(switching library version to 3.0.0 and behaviour is as expected).
Thanks for your help and for a great library!
The text was updated successfully, but these errors were encountered: