Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Content at Customer Approval Flow. #4484

Closed
drasticdpk opened this issue Sep 7, 2021 · 7 comments
Closed

Notification Content at Customer Approval Flow. #4484

drasticdpk opened this issue Sep 7, 2021 · 7 comments

Comments

@drasticdpk
Copy link
Collaborator

Reference
image

Scenario

  1. If there is only one milestone and it is approved by customer.

Message should be "Milestone has been approved by the customer."

  1. If we have 3 milestone, out of them 2 is already on Active state. Once another remaining milestone is approved by customer, now it is showing "All the milestone(s) has been approved by the customer" is it expected ?

  2. Is it possible to list the milestones that were approved in the notification?
    Reference Communication : https://topcoder.slack.com/archives/CBYPB0YBF/p1631021077012700?thread_ts=1630986905.010400&cid=CBYPB0YBF

Please suggest.
cc @ajefts @RishiRajSahu

@RishiRajSahu
Copy link
Contributor

we just have to update the existing text to -

The following milestone(s) has been approved:  
 - m1
 - m2

So it will include all the scenarios of 1 or more milestones being approved.

@elkhawajah
Copy link
Contributor

Created a PR

@drasticdpk
Copy link
Collaborator Author

Reference
image

image

@drasticdpk
Copy link
Collaborator Author

@elkhawajah please confirm.

@drasticdpk
Copy link
Collaborator Author

we just have to update the existing text to -

The following milestone(s) has been approved:  
 - m1
 - m2

@elkhawajah here the m1 and m2 are approved milestone right ?

@drasticdpk
Copy link
Collaborator Author

Verified on dev mode.
Reference
image

@drasticdpk
Copy link
Collaborator Author

Verified on Prod mode.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants