Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicker at the end of transition animation. #14

Open
dannybabiy opened this issue Oct 18, 2013 · 2 comments
Open

Flicker at the end of transition animation. #14

dannybabiy opened this issue Oct 18, 2013 · 2 comments

Comments

@dannybabiy
Copy link

If the two transitioning views have transparent backgrounds, you see a flicker at the end of the animation.

I resolved it by adding the following in ADDualTransition.m, at the end of finishInit

_inAnimation.fillMode = _outAnimation.fillMode = kCAFillModeForwards;
_inAnimation.removedOnCompletion = _outAnimation.removedOnCompletion = NO;

I haven't tested across all transitions, but it seems to do the trick for ADSwipeTransition.

@farfromrefug
Copy link
Contributor

That s a good start but you might create a memory leak as the animation object is never removed from the layer.
What i added was use a key for the _inAnimation and _outAnimation when adding them and first clear the animation

    [viewIn.layer removeAnimationForKey:kAdKey];
    [viewOut.layer removeAnimationForKey:kAdKey];
    [viewIn.layer addAnimation:self.inAnimation forKey:kAdKey];
    [viewOut.layer addAnimation:self.outAnimation forKey:kAdKey];

I still have to test it deeply with instruments

@mrjosa
Copy link

mrjosa commented Jan 5, 2016

It happens for me as well, totally unusable with this bug :( Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants