Unable to resolve orig.tar.gz already in repository for update-only uploads

[directhex]

In Debian, if I upload foo_1.0-1, then four files go to the archive:

• foo_1.0.orig.tar.bz2
• foo_1.0-1.debian.tar.gz
• foo_1.0-1.dsc
• foo_1.0-1_source.changes

If I then upload a bugfix to foo 1.0, only three files go up:

• foo_1.0-2.debian.tar.gz
• foo_1.0-2.dsc
• foo_1.0-2_source.changes

Note that foo_1.0.orig.tar.bz2 is skipped. It is not mentioned in foo_1.0-2_source.changes. The upload succeeds, because even though foo_1.0-2.dsc mentions foo_1.0.orig.tar.bz2, that file (with matching checksum) is already in the archive from the previous upload.

Aptly fails in this scenario.

release-manager@origin-download:~$ grep orig tmp.cIa2pqX4aV/mono_4.5.2.61-0nightly2_source.changes 
release-manager@origin-download:~$ grep orig tmp.cIa2pqX4aV/mono_4.5.2.61-0nightly2.dsc | tail -1
 a95dca13646aaf1b9247a379f69550d7 82640582 mono_4.5.2.61.orig.tar.bz2
release-manager@origin-download:~$ md5sum /srv/aptly/pool/a9/5d/mono_4.5.2.61.orig.tar.bz2
a95dca13646aaf1b9247a379f69550d7  /srv/aptly/pool/a9/5d/mono_4.5.2.61.orig.tar.bz2
release-manager@origin-download:~$ aptly repo include -accept-unsigned=true -repo=nightly tmp.cIa2pqX4aV/mono_4.5.2.61-0nightly2_source.changes
Loading repository nightly for changes file mono_4.5.2.61-0nightly2_source.changes...
[!] Unable to import file /tmp/aptly479785683/mono_4.5.2.61.orig.tar.bz2 into pool: open /tmp/aptly479785683/mono_4.5.2.61.orig.tar.bz2: no such file or directory
[!] Some files were skipped due to errors:
  tmp.cIa2pqX4aV/mono_4.5.2.61-0nightly2.dsc
ERROR: some files failed to be added

aptly should always consider its own pool when resolving orig files, on processing dsc files. This is how dak, launchpad and reprepro handle things.

[smira]

I forgot to update here, but it got fixed as #278