Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain backward compatibility in new task-based API #974

Closed
lbolla opened this issue Aug 31, 2021 · 2 comments
Closed

Maintain backward compatibility in new task-based API #974

lbolla opened this issue Aug 31, 2021 · 2 comments

Comments

@lbolla
Copy link
Contributor

lbolla commented Aug 31, 2021

The new task-based API calls implemented in the "molior-rebase" branch is backward incompatible: calls to API endpoints return a "Task" instead of the result of the action performed (e.g. mirror delete).

We want to be backward compatible and be able to have both "task-based" (aka "asynchronous") and "synchronous" API calls. A user-defined config option should control the behavior.
@lbolla
Copy link
Contributor Author

lbolla commented Sep 20, 2021

Our internal integration tests pass. The next step is to be able to run aptly official "system" tests, which don't currently run because of #973

@lbolla
Copy link
Contributor Author

lbolla commented Sep 22, 2021

See #971 (comment)

System tests have been fixed in b395a85 on the "molior-rebase" branch.

@lbolla lbolla closed this as completed Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lbolla