Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2x missing x2 #50

Open
jisa opened this issue Apr 4, 2024 · 0 comments
Open

2x missing x2 #50

jisa opened this issue Apr 4, 2024 · 0 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@jisa
Copy link

jisa commented Apr 4, 2024

Hello, thanks for making Madgwick filter so easily available on Arduinos!

Are you aware of the analysis in https://github.com/RideBeeline/madgwick-investigation?

It reveals that the code here is missing two multiplications by two. What is called two bx and two bz here is in fact bx and bz.

It can be fixed by, for example, adding these two lines.

After reading the original paper (pdf) and a Python implementation, I support the conclusion of the analysis.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jisa @per1234